Boy's had enough drama / trauma lol. Why'd he go and become wizard SWAT?

I hope he gave a few DADA class specials at Hogwarts coz he was always talented as a teacher

^I agree, he should've been a DADA teacher.

I think it fits him. Besides, it's the only career we really saw him consider.

I would have loved DADA teacher or Quidditch star, since he loved the sport so much.
On the other hand, being an auror fits his personality. I think he would have found a way to get involved in dark wizards hunt somehow, might as well make it official.
Being a teacher at Hogwarts must be difficult when you have a family. I think the teachers live at the castle, no?
I like to think that maybe later in life he decided to change career and teach the younger generation all he knows. Who's better suited to do it but the hero of the Wizarding World and ex-auror?

^I think the teachers do live in the castle. Maybe some families live nearby in Hogsmeade?